Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

North lines pattern becomes skewed #1870

Closed
pkturner opened this issue Feb 7, 2021 · 6 comments · Fixed by #1902
Closed

North lines pattern becomes skewed #1870

pkturner opened this issue Feb 7, 2021 · 6 comments · Fixed by #1902
Milestone

Comments

@pkturner
Copy link
Contributor

pkturner commented Feb 7, 2021

Steps to reproduce

  1. Create a new map, with a CRS, and with symbol set ISOM 2017-2.
  2. Add an area of North lines, symbol 601.2.
  3. Use the Georeferencing dialog to adjust the declination.
  4. Answer "Yes" to "Do you want to rotate the map accordingly?"

Actual behaviour

The North lines become skewed from the vertical.

Expected behaviour

While the object positions and shapes rotate, the North lines remain parallel to the sides of the map.

Configuration

Mapper Version: master-v20201227.4 (v0.9.4 behaves as expected.)
Operating System: MacOS 11.2 Big Sur; also seen on Linux

Note

Direct use of the "Rotate map" dialog has similar unexpected results.

@dl3sdo
Copy link
Member

dl3sdo commented Feb 7, 2021

The pattern keeps its direction if the 'adjustable per object' checkmark is removed for the symbol.

@lpechacek
Copy link
Member

As @dl3sdo pointed out, OCAD symbol set has the North lines area non-rotatable while Mapper has them rotatable. Thinking about the pros and cons, I recalled the times when there was no North lines area and OCAD had the Vertical lines tool for the map finishing. So in the OCAD world, if you use the Vertical lines tool to draw the north lines, the lines will be skewed after map rotation. If you use the area symbol, the lines will point to the map north. If you, for whatever reason, mix areas and lines ... sigh...

In the Mapper world, no matter if you use lines or the area symbol, the lines will point in the same direction. I don't say it's "better" but the result is consistent. Just my 0.02 €.

@pkturner
Copy link
Contributor Author

pkturner commented Feb 8, 2021

I don't have a strong notion of what the behavior should be. It's reported to bring attention to this change, and ensure that it gets some thought.

@dg0yt
Copy link
Member

dg0yt commented Feb 19, 2021

IMO the current setting in the symbol sets is wrong, at least as long as Mapper implies that magnetic north is "up".

@pkturner
Copy link
Contributor Author

the current setting in the symbol sets is wrong

Yes, I thought changing the default for the symbol might be a good fix.

As I understand it, ISOM no longer allows this:
IMG_9725S

@dg0yt
Copy link
Member

dg0yt commented Feb 23, 2021

As I understand it, ISOM no longer allows this [...]

Even ISOM2000 stated: "The sides of the map should be parallel to the magnetic north lines." (section 2.2, last paragraph).

People may edit such maps anyway, but they may have to enable the "adjustable per objects" for all symbols. (Possible exception symbols which interfer with some physical printing screens.)


Side note: What are the sides of the map, anyway? Coming from radio orienteering/ARDF, I'm used to applying advanced Origami magic to printed maps, in order to produce the minimum size which lets me draw bearings over the whole competition area. And for orienteering, my Origami creates even smaller artifacts ;-)

dg0yt added a commit that referenced this issue Mar 10, 2021
Rotation is not adjustable per object. Resolves GH-1870.
@dg0yt dg0yt added this to the v0.9.5 milestone Mar 10, 2021
dg0yt added a commit that referenced this issue Mar 10, 2021
Rotation is not adjustable per object. Resolves GH-1870.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants