Syntax Error in PrivacyLocationManager? #10
Comments
Remove tabs and over long lines, and move comments inwards. This can also be reverted independantly of the merge if wbedard wants to push his more refined style changes. I created an issue, reference #10, this will (attempted to) be resolved separately as well.
Remove tabs and over long lines, and move comments inwards. This can also be reverted independantly of the merge if wbedard wants to push his more refined style changes. I created an issue, reference #10, this will (attempted to) be resolved separately as well.
|
I have just checked the code in notepad++ which shows vertical lines for every connected bracket and it seems the single { in the line above the catch (PrivacyServiceException e) is out of place. Also the bracket in the if clause above that seems to have no closing bracket, so it seems the last else above the catch is never called. |
|
Ah, now we are getting somewhere! Thanks for taking the time to double check that for me, I was hoping someone would take a look. That is, as you saw, just what it looked like to me. edit: oh, and as an aside, those are actually not references to this issue. Those correspond to an internal system I am employing to keep track of my eventual rebases. I am trying to separate the merge into feature related commits. and it has taken an entire infrastructure to keep that hope afloat. My apologies for the spam notifications, |
|
No problem, big kudos for you for porting the whole framework. |
I think that there is an error regarding the placement of brackets in the PrivacyLocationManager. Maybe my eyes are playing tricks on me, because I have been fixing up the code for hours.
But it looks like the requestLocationUpdates method has a closing bracket out of place. I am trying to get the long lines gone and there is an overabundance of nesting in this class, I was thinking about refactoring it while I was just getting rid of the tabs.
Look at the top of that method, there are two opening braces at the top, for PendingIntent and synchronized (lock). I think that one of the related closing brackets is in front of the
} catch (PrivacyServiceException e) {line. I do not see where that goes anyhow.I will push some commits tonight. They are only clean up and style commits for right now, since I am adding the merge feature by feature. I am almost done with a commit adding the PrivacyDebugger, which I will push for review afterwards. But I will present what i think is the fix then.
Anyway, if someone could look over either my clean up or the original (maybe in the straight PDroid2.0 branch, which is jb-mr1-release-pdroid2.0 branch.
we have a long standing bug in Cell Tower Location as well, which makes this doubly suspicious. But maybe I am playing tricks with myself and ten hours of managing indents has me unneccessarily paranoid.
The text was updated successfully, but these errors were encountered: