Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictive PEC: use the monotonic clock rather than the system wall clock #1267

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

agalasso
Copy link
Contributor

GP guider needs accurate time interval measurements, and is not interested in the wall clock. std::chrono::steady_clock is a better choice than system_clock.

Testing:

  • gp guider unit tests pass

@agalasso agalasso requested a review from bwdev01 December 16, 2024 00:25
Copy link
Contributor

@bwdev01 bwdev01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this should eliminate an obvious weakness

@agalasso agalasso force-pushed the andy/clang-format-gp-guider-source-files branch from 4b08eff to 4b57797 Compare December 21, 2024 22:26
Base automatically changed from andy/clang-format-gp-guider-source-files to master December 21, 2024 22:26
…lock

GP guider needs accurate time interval measurements, and is not interested
in the wall clock.  std::chrono::steady_clock is a better choice than system_clock.

Testing:
 - gp guider unit tests pass
@agalasso agalasso force-pushed the andy/GPGuider-use-steady_clock branch from bdafcc7 to b6bb34f Compare December 21, 2024 22:27
@agalasso agalasso merged commit 5470fc4 into master Dec 21, 2024
4 checks passed
@agalasso agalasso deleted the andy/GPGuider-use-steady_clock branch December 21, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants