Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Ubuntu 24.10 #1289

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Fix build with Ubuntu 24.10 #1289

merged 1 commit into from
Jan 12, 2025

Conversation

pchev
Copy link
Contributor

@pchev pchev commented Jan 12, 2025

While it work fine with previous version of Ubuntu, the last version 24.10 fail to build with this error:

/<<PKGBUILDDIR>>/contributions/MPI_IS_gaussian_process/tests/gaussian_process/gp_guider_test.cpp:555:25: error: ‘setw’ is not a member of ‘std’
  555 |         outfile << std::setw(8) << GPG->GetGPHyperparameters()[PKPeriodLength] << "\n";
      |                         ^~~~
/<<PKGBUILDDIR>>/contributions/MPI_IS_gaussian_process/tests/gaussian_process/gp_guider_test.cpp:120:1: note: ‘std::setw’ is defined in header ‘<iomanip>’; this is probably fixable by adding ‘#include <iomanip>’
  119 | #include "guide_performance_tools.h"
  +++ |+#include <iomanip>

Applying the suggest change work, the package for 24.10 is now in the PPA and I tested it work without problem.
Probably "iomanip" was previously included from another header but no more now.

I not test with Windows and Mac, it may be good to do it before to merge.

Copy link
Contributor

@agalasso agalasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrick!
Confirmed the fix is good for Windows, Mac, and a Manjaro system.

@agalasso agalasso merged commit 0927de6 into OpenPHDGuiding:master Jan 12, 2025
2 checks passed
knro pushed a commit to knro/phd2 that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants