Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autotimer] hidden option encoding #1018

Merged
merged 2 commits into from
Nov 19, 2024
Merged

[autotimer] hidden option encoding #1018

merged 2 commits into from
Nov 19, 2024

Conversation

Dima73
Copy link
Contributor

@Dima73 Dima73 commented Nov 19, 2024

-this need for python3
File
"/usr/lib/enigma2/python/Plugins/Extensions/AutoTimer/AutoTimer.py", line 322, in parseTimer

builtins.AttributeError: 'str' object has no attribute 'decode'

-this need for python3
File
"/usr/lib/enigma2/python/Plugins/Extensions/AutoTimer/AutoTimer.py",
line 322, in parseTimer

builtins.AttributeError: 'str' object has no attribute 'decode'
Copy link
Member

@littlesat littlesat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove them and do not comment them out when they are not needed anymore

@WanWizard
Copy link
Member

The issue I have with this, is that it doesn't fix the root cause of the problem, the encoding issue. Instead a a bytesarray with non-UTF8, in Python3 you'll have a string object with non-UTF-8.

So imho the setting and the fix is still needed, the code needs to be made Python3 compliant (which is not easy if you don't know the source encoding).

-this need for python3
@Dima73
Copy link
Contributor Author

Dima73 commented Nov 19, 2024

The issue I have with this, is that it doesn't fix the root cause of the problem, the encoding issue. Instead a a bytesarray with non-UTF8, in Python3 you'll have a string object with non-UTF-8.

So imho the setting and the fix is still needed, the code needs to be made Python3 compliant (which is not easy if you don't know the source encoding).

In other images this has long been removed.

@WanWizard
Copy link
Member

And that proves it is ok?

@WanWizard WanWizard merged commit 129f33d into OpenPLi:python3 Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants