Open
Conversation
…"titles" and remove unused content search logic.
Member
|
Member
|
Member
|
@tenzinsamten average response time for the scope all is around 2.5 second 
we have make the content fetch faster. still needs improvement though😁 |
…alt_incipit_titles to be optional in the text metadata model.
… and imports to improve code clarity and maintainability.
…ng test cases - Implement tests for `knowledge_base_search` with scopes: 'all', 'title', and 'author'. - Validate responses for different scenarios including empty results and custom pagination. - Ensure proper mocking of service calls to verify expected behavior in tests. - Refactor existing tests for clarity and consistency in assertions.
…proved type hinting and clarity. Update return type of knowledge_base_search in search_service.py to support union types.
…efault values for improved clarity and maintainability.
|
tenzinsamten
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API change
Refactored endpoint
/text/title-search( Old endpoint -> no need to delete for time being )/search/knowledge-baseAdded
scopeparameter to control the search mode:all(default) — searches across title, author, and content , response are way smaller then the actual title and author and content fetched saperately.title— searches only titlesauthor— searches only authorsExample requests
All:
/search/knowledge-base?query=...&scope=allTitle only:
/search/knowledge-base?query=...&scope=titleAuthor only:
/search/knowledge-base?query=...&scope=authorContent only: (this feature is not implemented since we already have a saperate endpoint that manages content only)
which is /search/multilingual
/search/knowledge-base?query=...&scope=content