response_update #461
Open
response_update #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzinsamten
requested changes
Feb 12, 2026
pecha_api/search/search_views.py
Outdated
| return await get_url_link_service(pecha_segment_id) No newline at end of file | ||
| async def get_url_link(pecha_segment_id: str) -> SegmentLinkResponse: | ||
| result = await get_url_link_service(pecha_segment_id) | ||
| if result is None: |
Contributor
There was a problem hiding this comment.
exception should be thrown from the service and not from the view/controller
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.