Itemshop return valid definitions#299
Merged
MikeJeffers merged 1 commit intoDevelopmentfrom Apr 6, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the result of disabling entitydefaults in the DB, when
EntityDefault.Get(id)is called, it will return def:0 undefined for disabled defaults.Everything is fine right up until the client receives such a definition and it crashes.
The client doesn't crash in other contexts where a disabled item might be returned, but whether or not this could be handled in the client isn't within the scope of this project.
The fix is to filter out the hidden/disabled ED's when queried.