Sort fields in PojoFieldFactory for deterministic order #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
BusinessIdentityTest.testToString
compares the result with a hardcoded string. However, the functionBusinessIdentity.toString
did not return the deterministic string. From code trace, the root cause is the methodPojoFieldFactory.getPojoFields
, which calls on Java's reflection apigetDeclaredFields
. There is no guarantee in order of the returned fields and thus, some tests can fail due to a different order:BusinessIdentityTest.testToString
BusinessIdentityTest.testGetHashCode
This PR proposes to sort the returned fields and make it deterministic.