Skip to content

Commit

Permalink
fix: round 3 of attempting to fix coverage issues
Browse files Browse the repository at this point in the history
  • Loading branch information
kilpatty committed Nov 30, 2023
1 parent 2ad8b94 commit 557cafb
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ rlimit = "0.9.1"
parking_lot = "0.12"

[dev-dependencies]
coverage-helper = "0.2"
tokio = { version = "1", features = ["test-util"] }
tokio-test = "0.4.2"
criterion = {version = "0.4", features = ["async_tokio"]}
Expand Down
6 changes: 3 additions & 3 deletions server/src/ban_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ mod tests {
use super::*;
use tokio_test::{assert_err, assert_ok};

#[cfg_attr(coverage_nightly, no_coverage)]
#[cfg_attr(coverage_nightly, coverage(off))]
#[tokio::test]
async fn single_ban_expires() -> anyhow::Result<()> {
let cancel_token = CancellationToken::new();
Expand All @@ -354,7 +354,7 @@ mod tests {
Ok(())
}

#[cfg_attr(coverage_nightly, no_coverage)]
#[cfg_attr(coverage_nightly, coverage(off))]
#[tokio::test]
async fn ban_extended() -> anyhow::Result<()> {
let cancel_token = CancellationToken::new();
Expand Down Expand Up @@ -400,7 +400,7 @@ mod tests {
Duration::from_millis(n)
}

#[cfg_attr(coverage_nightly, no_coverage)]
#[cfg_attr(coverage_nightly, coverage(off))]
#[tokio::test]
async fn graceful_shutdown() -> anyhow::Result<()> {
let cancel_token = CancellationToken::new();
Expand Down
4 changes: 2 additions & 2 deletions server/src/id_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ mod tests {
use super::*;
use tokio_test::assert_ok;

#[cfg_attr(coverage_nightly, no_coverage)]
#[cfg_attr(coverage_nightly, coverage(off))]
#[tokio::test]
async fn idx_allocations() {
let id_manager = IDManager::new(0);
Expand All @@ -120,7 +120,7 @@ mod tests {
assert_eq!(rolled_id, SessionID::from(0));
}

#[cfg_attr(coverage_nightly, no_coverage)]
#[cfg_attr(coverage_nightly, coverage(off))]
#[tokio::test]
async fn basic_idx_allocations_with_prefix() {
let id_manager = IDManager::new(9);
Expand Down
1 change: 0 additions & 1 deletion server/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![cfg_attr(coverage_nightly, feature(coverage_attribute))]
#![warn(clippy::pedantic)]
#![allow(clippy::module_name_repetitions)]
//@todo fix this.
Expand Down

0 comments on commit 557cafb

Please sign in to comment.