Snap redux #269
Merged
Snap redux #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Issue #266) All this does is add HTTP_FIELD_xxx enumerations and the corresponding strings to allow libcups implementations of HTTP clients/servers that send/receive them. For the subject bug we'll still need to do a bunch of work in cupsd (later).
michaelrsweet
added
enhancement
tillkamppeter
added a commit
that referenced
this pull request
Oct 9, 2021
Some variable declarations got lost by the changes which made the code not building.
tillkamppeter
added a commit
to OpenPrinting/cups-snap
that referenced
this pull request
Oct 9, 2021
CUPS' Support for running in a Snap and for Snap mediation (allowing administrative requests from fully confined Snaps only if they plug "cups-control") got cleaned up and simplified, as it had some options we do not need any more. With this also the ./configure option to build CUPS for use in this Snap has changed from "--enable-snapped-cupsd" to "--with-container=snap". Also any other ./configure options to fine-tune the Snap support got removed as the alternatives do not actually make sense. This commit changes the ./configure command line appropriately. See OpenPrinting/cups#269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly simplifies snap/AppArmor support. The configure options have been limited to "--with-container=..." where currently we support "none" (the default) and "snap" (for snapcraft.io). The config.h defines have been normalized (
HAVE_LIBxxxandCUPS_SNAP) and we always support snapped clients if libsnapd-glib and libapparmor are available.cupsd now only supports the libsnapd-glib API to snapctl and not the external program - seems to me like we've gone past the "supporting old snapd" phase and executing external programs has both performance and security implications. I did a bunch of cleanup/simplification of the snap check logic as well, fixed the logging (errors should be errors, don't include the function name in the message, normalized the messaging), and made sure the code conforms to our style guide...