Skip to content

Commit

Permalink
Add implementation note explaining why we implement deprecated hash f…
Browse files Browse the repository at this point in the history
…unctions

and why we have our own HMAC implementation.
  • Loading branch information
michaelrsweet committed Apr 9, 2023
1 parent 00f35eb commit baa1421
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion cups/hash.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Hashing function for CUPS.
// Hashing functions for CUPS.
//
// Copyright © 2022-2023 by OpenPrinting.
// Copyright © 2015-2019 by Apple Inc.
Expand All @@ -22,6 +22,16 @@
#endif // HAVE_OPENSSL


//
// Note: While both GNU TLS and OpenSSL offer HMAC functions, they also exclude
// certain hashes depending on the version of library and whatever patches are
// applied by the OS vendor/Linux distribution. Since printers sometimes rely
// on otherwise deprecated/obsolete hash functions for things like PIN printing
// ("job-password"), and since such uses already have poor security regardless
// of the hash function used, it is more important to provide guaranteed
// implementations over some imaginary notion of "guaranteed security"...
//

//
// Local functions...
//
Expand Down

0 comments on commit baa1421

Please sign in to comment.