Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipp test is not skipped for resolution attribute. #63

Closed
sahusara opened this issue Aug 21, 2023 · 2 comments
Closed

Ipp test is not skipped for resolution attribute. #63

sahusara opened this issue Aug 21, 2023 · 2 comments
Assignees
Labels
bug Something isn't working priority-low
Milestone

Comments

@sahusara
Copy link
Contributor

sahusara commented Aug 21, 2023

ipptool: Bad resolution value "" on line 14 of 'resolution.test'.

Here is the content of resolution.test file.

{
	SKIP-IF-NOT-DEFINED PRINTER_RESOLUTION
	NAME "Validate-Job: resolution"
	OPERATION Validate-Job
	GROUP operation-attributes-tag
	ATTR charset attributes-charset utf-8
	ATTR naturalLanguage attributes-natural-language en
	ATTR uri printer-uri $uri
	ATTR name requesting-user-name $user
	ATTR mimeMediaType document-format application/octet-stream
	
	GROUP job-attributes-tag
	ATTR resolution printer-resolution $PRINTER_RESOLUTION
	# ATTR keyword sides $PRINTER_RESOLUTION #This line is for testing if the test is skipped.

	STATUS successful-ok
}

run this using below command to reproduce the issue.
ipptool -vt ipp:///ipp/print resilution.test

By defining PRINTER_RESOLUTION test case passes but how to skip the resolution.
ipptool -vt ipp:///ipp/print -d PRINTER_RESOLUTION=600dpi resilution.test

Note: It works for the keyword attribute.

@michaelrsweet
Copy link
Member

This is probably because an empty string is a valid keyword value but not a valid resolution value... Will see what we can do here...

@michaelrsweet michaelrsweet self-assigned this Aug 22, 2023
@michaelrsweet michaelrsweet added bug Something isn't working priority-low labels Aug 22, 2023
@michaelrsweet michaelrsweet added this to the Stable milestone Aug 22, 2023
@michaelrsweet michaelrsweet modified the milestones: Stable, v3.0 Sep 4, 2023
@michaelrsweet michaelrsweet modified the milestones: v3.0, Stable Oct 2, 2023
@michaelrsweet
Copy link
Member

[master 4816d4c] Allow empty string for resolution values (Issue #63)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low
Projects
None yet
Development

No branches or pull requests

2 participants