Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpConnectAgain should require the same X.509 certificate #90

Closed
michaelrsweet opened this issue Sep 26, 2024 · 2 comments
Closed

httpConnectAgain should require the same X.509 certificate #90

michaelrsweet opened this issue Sep 26, 2024 · 2 comments
Assignees
@michaelrsweet
Labels
bug Something isn't working priority-high security Security issue
Milestone
v3.0

Comments

@michaelrsweet
Copy link
Member

httpConnectAgain doesn't make sure that the new connection is using the same X.509 certificate as the original connection. The new connection should either have the same certificate or pass strict cupsGetCredentialsTrust tests.
@michaelrsweet michaelrsweet added bug Something isn't working priority-high security Security issue labels Sep 26, 2024
@michaelrsweet michaelrsweet added this to the v3.0 milestone Sep 26, 2024
@michaelrsweet michaelrsweet self-assigned this Sep 26, 2024
@michaelrsweet
Copy link
Member Author

Note: Since the connection address is cached in http_t, exploiting this issue is non-trivial.

michaelrsweet added a commit that referenced this issue Oct 12, 2024
@michaelrsweet
Re-validate server cert on re-connect (Issue #90)
2a5a0a2
@michaelrsweet
Copy link
Member Author

[master 2a5a0a2] Re-validate server cert on re-connect (Issue #90)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
bug Something isn't working priority-high security Security issue
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@michaelrsweet