build: fix failure to correctly link to zlib #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for the header is NOT sufficient when utilizing its shared library symbols. Look it up with pkg-config explicitly, and explicitly add it to ensure that at runtime, libppd has its own DT_NEEDED dependency on libz.so; if libppd successfully links at all -- not a given, if -Wl,-no-undefined is used -- then it *may* transitively get libz.so from its recursive dependencies, but this is no guarantee at all. Fixes failure to build discovered at https://bugs.gentoo.org/920273
eli-schwartz
force-pushed
the
zlib-pkgconfig
branch
from
1b843cf
to
e614c21
Compare
|
Thanks a lot for the fix, and sorry for having overlooked it in the first place. |
|
No big deal, the important thing is to get it in before the next tagged release. |
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Mar 17, 2024
Closes: https://bugs.gentoo.org/920273 Upstream-PR: OpenPrinting/libppd#32 Upstream-Commit: OpenPrinting/libppd@a040f26 Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 21, 2024
Closes: https://bugs.gentoo.org/920273 Upstream-PR: OpenPrinting/libppd#32 Upstream-Commit: OpenPrinting/libppd@a040f26 Signed-off-by: orbea <orbea@riseup.net> Closes: #35780 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for the header is NOT sufficient when utilizing its shared library symbols. Look it up with pkg-config explicitly, and explicitly add it to ensure that at runtime, libppd has its own DT_NEEDED dependency on libz.so; if libppd successfully links at all -- not a given, if -Wl,-no-undefined is used -- then it may transitively get libz.so from its recursive dependencies, but this is no guarantee at all.
Fixes failure to build discovered at https://bugs.gentoo.org/920273