-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use vcpkg in manifest mode #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses vcpkg's "manifest mode" where packages are read from `vcpkg.json`. As vcpkg automatically detects presence on `vcpkg.json` and switches to manifest mode, this required reworking how macOS libraries are built. I opted to split building of packages into per-architecture jobs to speed up the builds.
LibreSSL is API-compatible with OpenSSL, but much easier to build.
|
marijnvdwerf
approved these changes
Apr 11, 2024
I've filed OpenRCT2/OpenRCT2#21768 for the dirty visuals issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our usage of vcpkg from "classic" to "manifest" mode. Manifest mode uses
vcpkg.json
to detect which packages are needed.I encountered several issues when doing that switch, initially planned for Windows only:
vcpkg.json
, prompting me to update macos jobs at the same timeLC_ID_DYLIB
,LC_RPATH
,LC_LOAD_DYLIB
. Inspired by code already present for libzip, I updated freetype/brotli and left checks in place to detect possible issues of that kind in the futureI have requested users to test macos builds with those libraries and they came back positive. Tests included:
I tested Windows builds with updated libraries myself.