Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fr-FR: Apply #2284 & #2286 #2288

Merged
merged 2 commits into from
Mar 15, 2022
Merged

fr-FR: Apply #2284 & #2286 #2288

merged 2 commits into from
Mar 15, 2022

Conversation

ldanet
Copy link
Contributor

@ldanet ldanet commented Mar 14, 2022

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
fr-FR 0 (-9) 4 148

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 340 3 2133
ca-ES 91 4 100
cs-CZ 361 4 233
da-DK 9 4 484
de-DE 9 4 328
en-US 3298 0 390
eo-ZZ 9 4 83
es-ES 9 0 289
fi-FI 12 4 107
hu-HU 225 4 89
it-IT 28 4 305
ja-JP 114 11 659
ko-KR 9 4 171
nb-NO 334 3 2225
nl-NL 9 16 413
pl-PL 9 0 398
pt-BR 9 4 131
ru-RU 1402 1 110
sv-SE 9 0 340
tr-TR 196 10 396
vi-VN 35 6 3380
zh-CN 186 3 454
zh-TW 39 4 330

@Gymnasiast
Copy link
Member

Tagging @rmnvgr to check. (You may converse in French if necessary.)

rmnvgr
rmnvgr suggested changes Mar 15, 2022
View reviewed changes
data/language/fr-FR.txt Outdated
Comment on lines 3667 to 3671
STR_6463 :Excitation: {COMMA2DP32}
STR_6464 :Intensité
STR_6465 :Intensité: {COMMA2DP32}
STR_6466 :Nausée
STR_6467 :Nausée: {COMMA2DP32}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Espace insécable devant les deux points :

Suggested change
STR_6463 :Excitation: {COMMA2DP32}
STR_6464 :Intensité
STR_6465 :Intensité: {COMMA2DP32}
STR_6466 :Nausée
STR_6467 :Nausée: {COMMA2DP32}
STR_6463 :Excitation : {COMMA2DP32}
STR_6464 :Intensité
STR_6465 :Intensité : {COMMA2DP32}
STR_6466 :Nausée
STR_6467 :Nausée : {COMMA2DP32}

data/language/fr-FR.txt Outdated
STR_6465 :Intensité: {COMMA2DP32}
STR_6466 :Nausée
STR_6467 :Nausée: {COMMA2DP32}
STR_6468 :Pas encore connu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La fenêtre d’informations de l’attraction utilise « Pas encore disponible », il vaudrait mieux utiliser les mêmes termes (et ça évite de se poser la question de savoir si l’on accorde « connu » au masculin ou au féminin) :

Suggested change
STR_6468 :Pas encore connu
STR_6468 :Pas encore disponible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En anglais, la fenêtre d'information dit "Not yet available" mais ici c'était "Not yet known" d'où la différence. Mais bien vu pour l'accord, en l'occurence ç'aurait été connue pour excitation/nausée/intensité mais oui, disponible c'est plus sûr. Rien que pour ça ça me paraît une bonne idée de le changer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation does not need to be literal, on the contrary. In the case of EIN ratings, “not yet available” means they are still being calculated. Just make sure the info is communicated clearly (and consistently with the ride window) and don’t worry too much about the closeness of the translation.

(Sorry for replying in English, I can read French but my active skills are quite rusty.)

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
fr-FR 0 (-9) 4 148

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 340 3 2133
ca-ES 91 4 100
cs-CZ 361 4 233
da-DK 9 4 484
de-DE 9 4 328
en-US 3298 0 390
eo-ZZ 9 4 83
es-ES 9 0 289
fi-FI 12 4 107
hu-HU 225 4 89
it-IT 28 4 305
ja-JP 114 11 659
ko-KR 9 4 171
nb-NO 334 3 2225
nl-NL 9 16 413
pl-PL 9 0 398
pt-BR 9 4 131
ru-RU 1402 1 110
sv-SE 9 0 340
tr-TR 196 10 396
vi-VN 35 6 3380
zh-CN 186 3 454
zh-TW 39 4 330

@rmnvgr
Copy link
Contributor

rmnvgr commented Mar 15, 2022

@ldanet Merci !

@Gymnasiast Looks good to me!

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
fr-FR 0 (-9) 4 148

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 340 3 2133
ca-ES 91 4 100
cs-CZ 361 4 233
da-DK 9 4 484
de-DE 9 4 328
en-US 3298 0 390
eo-ZZ 9 4 83
es-ES 9 0 289
fi-FI 12 4 107
hu-HU 225 4 89
it-IT 28 4 305
ja-JP 114 11 659
ko-KR 9 4 171
nb-NO 334 3 2225
nl-NL 9 16 413
pl-PL 9 0 398
pt-BR 9 4 131
ru-RU 1402 1 110
sv-SE 9 0 340
tr-TR 196 10 396
vi-VN 35 6 3380
zh-CN 186 3 454
zh-TW 39 4 330

@ldanet
Copy link
Contributor Author

ldanet commented Mar 15, 2022

I had put regular spaces instead of non-breaking ones, hence the second force push to fix that. Thanks @rmnvgr for the review!

@Gymnasiast Gymnasiast merged commit 8f3d17c into OpenRCT2:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast left review comments

@rmnvgr rmnvgr rmnvgr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldanet @Gymnasiast @rmnvgr