Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es-ES: Apply #2678, #2679 + improve "wall" wording consistency #2686

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

dimateos
Copy link
Contributor

Applying for issue(s):

Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

es-ES 0 (-2) 1 304

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 73 2 1956
ca-ES 2 1 117
cs-CZ 382 0 246
da-DK 120 1 484
de-DE 2 1 352
en-US 3378 0 390
eo-ZZ 0 1 89
fi-FI 155 1 109
fr-CA 3961 0 0
fr-FR 2 1 160
hu-HU 114 1 116
it-IT 3 1 342
ja-JP 298 1 608
ko-KR 0 1 194
nb-NO 308 0 2165
nl-NL 2 13 451
pl-PL 140 1 380
pt-BR 0 1 146
ru-RU 1304 0 111
sv-SE 162 1 341
tr-TR 361 1 395
vi-VN 220 3 3260
zh-CN 2 1 82
zh-TW 115 0 332

@@ -3095,7 +3095,7 @@ STR_5935 :Borde del Terreno: {BLACK}{STRINGID}
STR_5936 :Dueño de la Tierra: {BLACK}{STRINGID}
STR_5937 :Sin dueño y no a la venta
STR_5938 :Nivel de Agua: {BLACK}{COMMA16}
STR_5939 :Remover vallas parque
STR_5939 :Eliminar vallas parque
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also become "del parque"? If I'm not mistaken the original string for this is exactly the same as the one you translated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I noticed it too after opening the PR, but I also noticed many "Remover" all around the file so I was gonna open another PR at some point addressing both things.

I can just fix that for this one if you want ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fitting since we're introducing a similar string.

Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

es-ES 0 (-2) 1 304

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 73 2 1956
ca-ES 2 1 117
cs-CZ 382 0 246
da-DK 120 1 484
de-DE 2 1 352
en-US 3378 0 390
eo-ZZ 0 1 89
fi-FI 155 1 109
fr-CA 3961 0 0
fr-FR 2 1 160
hu-HU 114 1 116
it-IT 3 1 342
ja-JP 298 1 608
ko-KR 0 1 194
nb-NO 308 0 2165
nl-NL 2 13 451
pl-PL 140 1 380
pt-BR 0 1 146
ru-RU 1304 0 111
sv-SE 162 1 341
tr-TR 361 1 395
vi-VN 220 3 3260
zh-CN 2 1 82
zh-TW 115 0 332

@tupaschoal tupaschoal merged commit 6b8a2ac into OpenRCT2:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants