Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update da-DK.txt #2688

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Update da-DK.txt #2688

merged 2 commits into from
Feb 1, 2024

Conversation

Copy link

github-actions bot commented Dec 7, 2023

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

da-DK 0 (-120) 0 (-1) 538 (+54)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 73 2 1956
ca-ES 2 1 117
cs-CZ 382 0 246
de-DE 2 1 352
en-US 3378 0 390
eo-ZZ 0 1 89
es-ES 0 1 304
fi-FI 155 1 109
fr-CA 3961 0 0
fr-FR 2 1 160
hu-HU 114 1 116
it-IT 3 1 342
ja-JP 298 1 608
ko-KR 0 1 194
nb-NO 308 0 2165
nl-NL 2 13 451
pl-PL 140 1 380
pt-BR 0 1 146
ru-RU 1304 0 111
sv-SE 162 1 341
tr-TR 361 1 395
vi-VN 220 3 3260
zh-CN 2 1 82
zh-TW 115 0 332

data/language/da-DK.txt Outdated Show resolved Hide resolved
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LPSGizmo, thanks for providing such a comprehensive update on da-DK!

I've left a handful of comments that require attention. Also I noticed you translated strings from more issues than you mentioned, so I edited your original post to mention those too.

data/language/da-DK.txt Outdated Show resolved Hide resolved
data/language/da-DK.txt Outdated Show resolved Hide resolved
data/language/da-DK.txt Outdated Show resolved Hide resolved
data/language/da-DK.txt Show resolved Hide resolved
data/language/da-DK.txt Show resolved Hide resolved
@LPSGizmo
Copy link
Contributor Author

should I fix the missing/wrong translations, and the create a new pull request?

@Gymnasiast
Copy link
Member

You don’t need to create a new one necessarily, you can just update this branch if you know how.

Alternatively, you can create smaller ones that only address a few issues each. But that is up to you.

data/language/da-DK.txt Outdated Show resolved Hide resolved
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

da-DK 2 (-120) 0 (-1) 534 (+50)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 75 2 1956
ca-ES 4 1 117
cs-CZ 384 0 246
de-DE 4 1 352
en-US 3380 0 389
eo-ZZ 2 1 89
es-ES 2 1 304
fi-FI 157 1 109
fr-CA 3963 0 0
fr-FR 4 1 160
hu-HU 116 1 116
it-IT 5 1 342
ja-JP 300 1 607
ko-KR 2 1 194
nb-NO 310 0 2165
nl-NL 4 13 451
pl-PL 142 1 380
pt-BR 2 1 146
ru-RU 1306 0 111
sv-SE 164 1 341
tr-TR 363 1 395
vi-VN 222 3 3259
zh-CN 4 1 82
zh-TW 117 0 331

@tupaschoal
Copy link
Member

@LPSGizmo I've applied the suggestions I made you agreed with and the suggestions you did, if no change is needed on STR_2753 after my comment, then I think we can go ahead and merge this :)

@Gymnasiast Gymnasiast merged commit 62244ef into OpenRCT2:master Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants