Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply #2794, #2801, #2806, #2814, #2815, #2821, #2826 #2834

Merged
merged 2 commits into from
May 20, 2024

Conversation

rmnvgr
Copy link
Contributor

@rmnvgr rmnvgr commented May 20, 2024

Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

fr-FR 0 (-19) 1 166

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 110 2 1913
ca-ES 24 1 121
cs-CZ 429 0 248
da-DK 19 0 564
de-DE 19 1 356
en-US 3391 0 392
eo-ZZ 0 1 89
es-ES 12 1 304
fi-FI 2 1 117
fr-CA 3976 0 0
hu-HU 7 0 120
it-IT 16 1 344
ja-JP 345 1 607
ko-KR 0 1 194
nb-NO 19 0 483
nl-NL 2 13 478
pl-PL 187 1 408
pt-BR 0 1 148
ru-RU 1351 0 111
sv-SE 102 1 353
tr-TR 408 1 397
uk-UA 31 34 1138
vi-VN 267 3 3227
zh-CN 0 1 35
zh-TW 162 0 333

@@ -3700,6 +3702,23 @@ STR_6619 :Ce type d’objet ne peut pas être restreint !
STR_6620 :Objet introuvable !
STR_6621 :Restreindre
STR_6622 :Restreint l’objet à l’éditeur de scénario et au mode bac à sable
STR_6623 :Tapez {SMALLFONT}help{MEDIUMFONT} pour une liste des commandes disponibles. Tapez {SMALLFONT}hide{MEDIUMFONT} pour cacher la console.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not show up correctly if the console it set to use the small font instead of medium - it will start off as a small font string and switch to medium after the first few words.

I guess the best option is to force the entire string to appear in medium font. Will need to be tested, though.

Suggested change
STR_6623 :Tapez {SMALLFONT}help{MEDIUMFONT} pour une liste des commandes disponibles. Tapez {SMALLFONT}hide{MEDIUMFONT} pour cacher la console.
STR_6623 :{MEDIUMFONT}Tapez {SMALLFONT}help{MEDIUMFONT} pour une liste des commandes disponibles. Tapez {SMALLFONT}hide{MEDIUMFONT} pour cacher la console.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know the console could use the small font. It'd look strange to only have the help text in medium font, I think it's better to use regular guillemets then.

@rmnvgr rmnvgr force-pushed the apply-2784-to-2826 branch from ecddbce to 1224cf6 Compare May 20, 2024 09:54
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

fr-FR 0 (-19) 1 166

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 110 2 1913
ca-ES 24 1 121
cs-CZ 429 0 248
da-DK 19 0 564
de-DE 19 1 356
en-US 3391 0 392
eo-ZZ 0 1 89
es-ES 12 1 304
fi-FI 2 1 117
fr-CA 3976 0 0
hu-HU 7 0 120
it-IT 16 1 344
ja-JP 345 1 607
ko-KR 0 1 194
nb-NO 19 0 483
nl-NL 2 13 478
pl-PL 187 1 408
pt-BR 0 1 148
ru-RU 1351 0 111
sv-SE 102 1 353
tr-TR 408 1 397
uk-UA 31 34 1138
vi-VN 267 3 3227
zh-CN 0 1 35
zh-TW 162 0 333

@Gymnasiast Gymnasiast merged commit a121b79 into OpenRCT2:master May 20, 2024
1 check passed
@rmnvgr rmnvgr deleted the apply-2784-to-2826 branch May 20, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants