Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1960>1920 in rev police car description #266

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

ZeeMaji
Copy link
Contributor

@ZeeMaji ZeeMaji commented Jan 15, 2024

The reverser coaster police car reskins from TT erroneously have "1960s-themed police cars" in their description when it should be "1920s-themed police cars" as these vehicles are from the roaring twenties set of objects. This fixes that.

Only en-gb has been fixed, changes for the other languages should be implemented in the languages repo.

The reverser coaster police car reskins from TT erroneously have "1960s-themed police cars" in their description when it should be "1920s-themed police cars" as these vehicles are from the roaring twenties set of objects. This fixes that.

Only en-gb has been fixed, changes for the other languages should be implemented in the languages repo
@Gymnasiast
Copy link
Member

Gymnasiast commented Jan 15, 2024

Only en-gb has been fixed, changes for the other languages should be implemented in the languages repo.

Technically, you’re right, but could you still modify all of them? The sync process is not automated and only carried out once in a blue moon.

@ZeeMaji
Copy link
Contributor Author

ZeeMaji commented Jan 15, 2024

I suppose i could, but won't they get reverted the next time a sync does happen? You'll have to keep that in mind on the languages repo.

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad that, for some reason, pt-BR was already right :D

objects/rct2tt/ride/rct2tt.ride.policecr.json Outdated Show resolved Hide resolved
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
@Gymnasiast Gymnasiast merged commit b8555c9 into OpenRCT2:master Jan 16, 2024
2 checks passed
@ZeeMaji ZeeMaji mentioned this pull request Jan 16, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants