Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully train dqn in gridworld #103

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

YiwenAI
Copy link
Collaborator

@YiwenAI YiwenAI commented Jun 7, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make commit-checks (required).

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #103 (38173b7) into main (ec9c2bd) will decrease coverage by 1.07%.
The diff coverage is 58.00%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   45.44%   44.38%   -1.07%     
==========================================
  Files         143      143              
  Lines        8909     8996      +87     
==========================================
- Hits         4049     3993      -56     
- Misses       4860     5003     +143     
Flag Coverage Δ
unittests 44.38% <58.00%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrl/drivers/offpolicy_driver.py 24.28% <0.00%> (-0.36%) ⬇️
openrl/modules/common/dqn_net.py 30.43% <20.00%> (-2.13%) ⬇️
openrl/buffers/offpolicy_replay_data.py 27.55% <56.57%> (-9.46%) ⬇️
openrl/envs/gridworld/gridworld_env.py 68.42% <70.00%> (-1.15%) ⬇️
openrl/algorithms/dqn.py 63.80% <100.00%> (+1.06%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@huangshiyu13 huangshiyu13 merged commit c73f599 into OpenRL-Lab:main Jun 8, 2023
@huangshiyu13 huangshiyu13 mentioned this pull request Jun 9, 2023
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants