Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more callbacks and callbacks tests #122

Merged
merged 4 commits into from
Jun 25, 2023

Conversation

huangshiyu13
Copy link
Member

@huangshiyu13 huangshiyu13 commented Jun 25, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make format (required).

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #122 (5583c34) into main (2c49437) will decrease coverage by 45.70%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #122       +/-   ##
==========================================
- Coverage   45.69%   0.00%   -45.70%     
==========================================
  Files         156     162        +6     
  Lines        9925   10239      +314     
==========================================
- Hits         4535       0     -4535     
- Misses       5390   10239     +4849     
Flag Coverage Δ
unittests 0.00% <0.00%> (-45.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrl/buffers/utils/util.py 0.00% <0.00%> (-81.97%) ⬇️
openrl/drivers/offpolicy_driver.py 0.00% <ø> (-19.36%) ⬇️
openrl/envs/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
openrl/envs/common/registration.py 0.00% <0.00%> (-73.08%) ⬇️
openrl/envs/toy_envs/__init__.py 0.00% <0.00%> (ø)
openrl/envs/toy_envs/bit_flipping_env.py 0.00% <0.00%> (ø)
openrl/envs/toy_envs/identity_env.py 0.00% <0.00%> (ø)
openrl/envs/toy_envs/multi_input_envs.py 0.00% <0.00%> (ø)
openrl/envs/vec_env/utils/numpy_utils.py 0.00% <0.00%> (-82.28%) ⬇️
openrl/envs/wrappers/util.py 0.00% <0.00%> (-62.97%) ⬇️
... and 11 more

... and 116 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant