Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sac #169

Merged
merged 1 commit into from
Jul 26, 2023
Merged

add sac #169

merged 1 commit into from
Jul 26, 2023

Conversation

zrz-sh
Copy link
Contributor

@zrz-sh zrz-sh commented Jul 26, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make format (required).

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #169 (ced47af) into main (8054f00) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##            main    #169    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        198     203     +5     
  Lines      11765   12117   +352     
======================================
- Misses     11765   12117   +352     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openrl/algorithms/sac.py 0.00% <0.00%> (ø)
openrl/configs/config.py 0.00% <0.00%> (ø)
openrl/drivers/offpolicy_driver.py 0.00% <0.00%> (ø)
openrl/modules/common/__init__.py 0.00% <0.00%> (ø)
openrl/modules/common/sac_net.py 0.00% <0.00%> (ø)
openrl/modules/networks/sac_network.py 0.00% <0.00%> (ø)
openrl/modules/sac_module.py 0.00% <0.00%> (ø)
openrl/runners/common/__init__.py 0.00% <0.00%> (ø)
openrl/runners/common/sac_agent.py 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

parser.add_argument(
"--var",
type=int,
default=3,
help="Control the exploration variance of the generated actions",
)
parser.add_argument(
"actor_lr", type=float, default=0.001, help="The learning rate of actor network"
"actor_lr", type=float, default=5e-4, help="The learning rate of actor network"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要改默认值

@huangshiyu13 huangshiyu13 merged commit a625602 into OpenRL-Lab:main Jul 26, 2023
This was referenced Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants