Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retro Environment #67

Merged
merged 4 commits into from
May 16, 2023
Merged

Add Retro Environment #67

merged 4 commits into from
May 16, 2023

Conversation

ChildTang
Copy link
Collaborator

@ChildTang ChildTang commented May 16, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make commit-checks (required).

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #67 (9efabfc) into main (8607c2d) will decrease coverage by 0.33%.
The diff coverage is 14.81%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   41.89%   41.56%   -0.33%     
==========================================
  Files         116      118       +2     
  Lines        7235     7297      +62     
==========================================
+ Hits         3031     3033       +2     
- Misses       4204     4264      +60     
Flag Coverage Δ
unittests 41.56% <14.81%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrl/envs/common/build_envs.py 85.71% <ø> (ø)
openrl/envs/common/registration.py 62.22% <0.00%> (-4.45%) ⬇️
openrl/envs/retro/__init__.py 0.00% <0.00%> (ø)
openrl/envs/retro/retro_convert.py 0.00% <0.00%> (ø)
openrl/modules/common/ppo_net.py 86.04% <0.00%> (ø)
openrl/modules/networks/utils/cnn.py 31.70% <11.11%> (-3.59%) ⬇️
openrl/envs/vec_env/base_venv.py 64.58% <25.00%> (ø)
openrl/__init__.py 100.00% <100.00%> (ø)
openrl/drivers/onpolicy_driver.py 95.16% <100.00%> (ø)
openrl/drivers/rl_driver.py 90.21% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many names in this file. env name of retro can be move to retro directory.

@huangshiyu13 huangshiyu13 merged commit dff448d into OpenRL-Lab:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants