Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update runners for off policy algorithm #71

Merged
merged 5 commits into from
May 16, 2023
Merged

Conversation

YiwenAI
Copy link
Collaborator

@YiwenAI YiwenAI commented May 16, 2023

Description

Update runners for off-policy development

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make commit-checks (required).

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #71 (9711a3b) into main (9efabfc) will decrease coverage by 0.54%.
The diff coverage is 26.77%.

❗ Current head 9711a3b differs from pull request most recent head af60806. Consider uploading reports for the commit af60806 to get more accurate results

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   41.56%   41.03%   -0.54%     
==========================================
  Files         118      122       +4     
  Lines        7297     7528     +231     
==========================================
+ Hits         3033     3089      +56     
- Misses       4264     4439     +175     
Flag Coverage Δ
unittests 41.03% <26.77%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrl/modules/common/dqn_net.py 0.00% <0.00%> (ø)
openrl/algorithms/dqn.py 19.76% <19.76%> (ø)
openrl/drivers/offpolicy_driver.py 26.15% <26.15%> (ø)
openrl/buffers/normal_buffer.py 80.00% <50.00%> (-2.61%) ⬇️
openrl/runners/common/rl_agent.py 87.14% <50.00%> (-2.20%) ⬇️
openrl/runners/common/dqn_agent.py 56.66% <56.66%> (ø)
openrl/runners/common/__init__.py 100.00% <100.00%> (ø)
openrl/runners/common/ppo_agent.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YiwenAI YiwenAI closed this May 16, 2023
@YiwenAI YiwenAI reopened this May 16, 2023
@YiwenAI YiwenAI merged commit 002caf0 into OpenRL-Lab:main May 16, 2023
@huangshiyu13 huangshiyu13 mentioned this pull request May 18, 2023
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant