Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retro #73

Merged
merged 20 commits into from
May 18, 2023
Merged

Add retro #73

merged 20 commits into from
May 18, 2023

Conversation

ChildTang
Copy link
Collaborator

@ChildTang ChildTang commented May 18, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make commit-checks (required).

@ChildTang ChildTang requested a review from huangshiyu13 May 18, 2023 04:18
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #73 (e2cfb87) into main (0a0fdc3) will increase coverage by 0.75%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   40.52%   41.28%   +0.75%     
==========================================
  Files         126      124       -2     
  Lines        7726     7671      -55     
==========================================
+ Hits         3131     3167      +36     
+ Misses       4595     4504      -91     
Flag Coverage Δ
unittests 41.28% <46.15%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrl/buffers/normal_buffer.py 82.60% <ø> (ø)
openrl/buffers/offpolicy_buffer.py 0.00% <0.00%> (ø)
openrl/buffers/offpolicy_replay_data.py 0.00% <0.00%> (ø)
openrl/envs/__init__.py 100.00% <ø> (ø)
openrl/envs/common/registration.py 66.66% <ø> (+4.44%) ⬆️
openrl/modules/common/dqn_net.py 32.55% <ø> (ø)
openrl/drivers/offpolicy_driver.py 25.71% <25.00%> (ø)
openrl/modules/dqn_module.py 58.53% <25.00%> (-1.47%) ⬇️
openrl/runners/common/dqn_agent.py 56.66% <33.33%> (ø)
openrl/modules/networks/q_network.py 69.81% <54.54%> (+69.81%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@huangshiyu13 huangshiyu13 merged commit 33500c7 into OpenRL-Lab:main May 18, 2023
@huangshiyu13 huangshiyu13 mentioned this pull request May 18, 2023
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants