Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add a second button in lmr for new request with prefill form #10130

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Caracol3
Copy link
Contributor

@Caracol3 Caracol3 commented Dec 19, 2024

close #9695

Edit: seen with @axrolld, now we withdraw the two buttons in the initial page when one of them is clicked.

@Caracol3 Caracol3 requested review from a team as code owners December 19, 2024 10:35
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (995c248) to head (f529649).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10130      +/-   ##
==========================================
- Coverage   81.49%   81.47%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104270   104304      +34     
  Branches      722      722              
==========================================
+ Hits        84970    84984      +14     
- Misses      19259    19279      +20     
  Partials       41       41              
Flag Coverage Δ
editoast 73.66% <ø> (-0.07%) ⬇️
front 89.21% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e-tests

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-new-request-enhancements branch from 5328fe1 to 63140ec Compare January 6, 2025 13:05
@Caracol3 Caracol3 requested a review from achrafmohye January 6, 2025 13:12
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-new-request-enhancements branch from 63140ec to a3a3eff Compare January 6, 2025 14:35
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both buttons open the same URL, the openNewWindow function no longer requires a parameter.

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-new-request-enhancements branch from a3a3eff to 1a90182 Compare January 7, 2025 15:57
@Caracol3 Caracol3 requested a review from kmer2016 January 7, 2025 15:59
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-new-request-enhancements branch from 1a90182 to 84b5a6e Compare January 8, 2025 10:41
- withraw new request buttons after clicking on it

Signed-off-by: Mathieu <mathieu.coulibaly@sncf.fr>
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-new-request-enhancements branch from 84b5a6e to f529649 Compare January 8, 2025 11:38
@Caracol3 Caracol3 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into dev with commit 9109fb7 Jan 8, 2025
27 checks passed
@Caracol3 Caracol3 deleted the mcy/front-lmr-new-request-enhancements branch January 8, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmr: front: clarify Démarrer une nouvelle requête buttons
5 participants