-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add a second button in lmr for new request with prefill form #10130
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10130 +/- ##
==========================================
- Coverage 81.49% 81.47% -0.02%
==========================================
Files 1058 1058
Lines 104270 104304 +34
Branches 722 722
==========================================
+ Hits 84970 84984 +14
- Misses 19259 19279 +20
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for e2e-tests
5328fe1
to
63140ec
Compare
63140ec
to
a3a3eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since both buttons open the same URL, the openNewWindow
function no longer requires a parameter.
a3a3eff
to
1a90182
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
1a90182
to
84b5a6e
Compare
- withraw new request buttons after clicking on it Signed-off-by: Mathieu <mathieu.coulibaly@sncf.fr>
84b5a6e
to
f529649
Compare
close #9695
Edit: seen with @axrolld, now we withdraw the two buttons in the initial page when one of them is clicked.