front: fix power restrictions reset when editing a train #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10134 +/- ##
==========================================
- Coverage 79.83% 79.81% -0.02%
==========================================
Files 1054 1054
Lines 105547 105537 -10
Branches 726 726
==========================================
- Hits 84261 84237 -24
- Misses 21244 21258 +14
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
force-pushed
the
cni/9902-fix-power-restrictions
branch
from
d559bd8 to
cb3ecb6
Compare
Add a state value isInitialized to avoid reseting the power restrictions when editing a train. Indeed, the pathfinding was launched by the 2 hooks (with infra and rollingStock), which reset the power restrictions, even when the user was editing a train. Now it won't be the case anymore. Signed-off-by: Clara Ni <clara.ni@outlook.fr>
clarani
force-pushed
the
cni/9902-fix-power-restrictions
branch
from
cb3ecb6 to
fb011a4
Compare
Akctarus
approved these changes
Dec 23, 2024
|
Thanks @Akctarus ! Yes, it is the expected behavior for now, because to add power restriction in the backend, we need to locate them with pathsteps ids ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9902
To test: