Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: Initialize the new version of the Map. #10280

Merged
merged 1 commit into from
Jan 9, 2025
Merged

front: Initialize the new version of the Map. #10280

merged 1 commit into from
Jan 9, 2025
+486 −23

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Jan 8, 2025 •
edited
Loading

closes #9776
This commit initializes the refacto of the Map component. The Map is now decoupled from the store. Specifically:

  • The zoom button callbacks no longer depend on the store.
  • Other buttons have been temporarily hidden.

This change allows multiple Map instances to be rendered on the same page without conflicts.

@kmer2016 kmer2016 requested review from a team as code owners January 8, 2025 08:15
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (e1ac027) to head (70085c5).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10280      +/-   ##
==========================================
+ Coverage   81.56%   81.63%   +0.06%     
==========================================
  Files        1062     1063       +1     
  Lines      104953   105416     +463     
  Branches      722      722              
==========================================
+ Hits        85606    86057     +451     
- Misses      19306    19318      +12     
  Partials       41       41
Flag Coverage Δ
editoast 73.60% <ø> (-0.04%) ⬇️
front 89.38% <100.00%> (+0.07%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmer2016 kmer2016 force-pushed the cnh/enable_interactivity_stdcm_result_map branch from 89dff49 to fbc8a55 Compare January 8, 2025 11:58
Maymanaf
Maymanaf requested changes Jan 8, 2025
View reviewed changes
@Yohh
Copy link
Contributor

Yohh commented Jan 8, 2025

just to be sure, is the name NewMap going to change when the refacto will be done or is it it's real and definitive name?

@kmer2016
Copy link
Contributor Author

kmer2016 commented Jan 8, 2025

just to be sure, is the name NewMap going to change when the refacto will be done or is it it's real and definitive name?

Oh no, the name will also change once the refactor is complete

@kmer2016 kmer2016 force-pushed the cnh/enable_interactivity_stdcm_result_map branch 2 times, most recently from 343322d to b225664 Compare January 8, 2025 16:57
@kmer2016 kmer2016 force-pushed the cnh/enable_interactivity_stdcm_result_map branch from b225664 to 77280aa Compare January 9, 2025 09:54
clarani
clarani approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@kmer2016
front: initialize the new version of the Map.
70085c5 
This commit initializes the new version of the Map component. The Map is now decoupled from the store. Specifically, the zoom button callbacks are detached from the store, while the other buttons are temporarily hidden.

Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
@kmer2016 kmer2016 force-pushed the cnh/enable_interactivity_stdcm_result_map branch from 29698c0 to 70085c5 Compare January 9, 2025 10:16
RomainValls
RomainValls approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested 👍

@kmer2016 kmer2016 enabled auto-merge January 9, 2025 10:33
@kmer2016 kmer2016 requested a review from Maymanaf January 9, 2025 10:38
Maymanaf
Maymanaf approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e-tests

@kmer2016 kmer2016 added this pull request to the merge queue Jan 9, 2025
Merged via the queue into dev with commit b9329c4 Jan 9, 2025
27 checks passed
@kmer2016 kmer2016 deleted the cnh/enable_interactivity_stdcm_result_map branch January 9, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh left review comments

@Maymanaf Maymanaf Maymanaf approved these changes

@clarani clarani clarani approved these changes

@RomainValls RomainValls RomainValls approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stdcm: front: make the result map great again
6 participants
@kmer2016 @codecov-commenter @Yohh @Maymanaf @clarani @RomainValls