Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: bump ui-core to 0.0.61 #10293

Merged
merged 2 commits into from
Jan 9, 2025
Merged

front: bump ui-core to 0.0.61 #10293

merged 2 commits into from
Jan 9, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 9, 2025

fix #9296
fix #8932

  • adapt comboBox

@clarani clarani requested a review from a team as a code owner January 9, 2025 08:36
@clarani clarani force-pushed the cni/bump-osrd-ui-61 branch from ab7bc33 to d290982 Compare January 9, 2025 08:41
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (e1ac027) to head (3a08a5f).
Report is 22 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10293      +/-   ##
==========================================
- Coverage   81.56%   81.56%   -0.01%     
==========================================
  Files        1062     1062              
  Lines      104953   105017      +64     
  Branches      722      722              
==========================================
+ Hits        85606    85655      +49     
- Misses      19306    19321      +15     
  Partials       41       41              
Flag Coverage Δ
editoast 73.64% <ø> (-0.01%) ⬇️
front 89.30% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani self-assigned this Jan 9, 2025
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working, just a few suggestions

@clarani clarani force-pushed the cni/bump-osrd-ui-61 branch from 21bd350 to d23dd36 Compare January 9, 2025 10:14
- adapt comboBox

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
… form

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/bump-osrd-ui-61 branch from d23dd36 to 3a08a5f Compare January 9, 2025 10:58
@clarani clarani enabled auto-merge January 9, 2025 11:03
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, some issues are still there but shouldn't block this bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
4 participants