-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gateway otlp config #10529
Fix gateway otlp config #10529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10529 +/- ##
==========================================
- Coverage 81.88% 81.88% -0.01%
==========================================
Files 1078 1078
Lines 107139 107139
Branches 724 724
==========================================
- Hits 87731 87728 -3
- Misses 19368 19371 +3
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've removed the configuration options for service name in Finally, I've remove the I still need to test more this |
9457bc9
to
82267bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
…ice name Let's use the standard `OTEL_SERVICE_NAME`. Let's also put that configuration variable directly in the `Dockerfile`. Finally, remove the `enable` which is a leftover from b154bad. Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
82267bc
to
ad7971d
Compare
service_name
does not work (we could delete it and use the default env var)figment::merge
seems to work the other way aroundOTEL_SERVICE_NAME
to docker files for all services