front: drop formatToIsoDate() #10845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/drop-iso-date-helpers
branch
from
3c7252a to
4d58dc6
Compare
emersion
force-pushed
the
emr/drop-iso-date-helpers
branch
from
4d58dc6 to
475e86b
Compare
emersion
changed the title
This is simpler and safer. No behavior change. Signed-off-by: Simon Ser <contact@emersion.fr>
No need to use a custom function to convert to an ISO string, the Date API already has this covered. Signed-off-by: Simon Ser <contact@emersion.fr>
The format doesn't matter too much here. toLocaleString() is better localized. Signed-off-by: Simon Ser <contact@emersion.fr>
This is now unused. This function was a bit weird, because it had two unrelated purposes: format a human-readable string with a fixed frenchy format, or format a machine-readable string for API purposes. The function also accepted strings and numbers as input (implicitly converting these to dates), making it so callers are less type-safe. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/drop-iso-date-helpers
branch
from
475e86b to
d0d6b8d
Compare
Synar
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
This function was a bit weird, because it had two unrelated purposes: format a human-readable string with a fixed frenchy format, or format a machine-readable string for API purposes. The function also accepted strings and numbers as input (implicitly converting these to dates), making it so callers are less type-safe.