Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix glyph generation on docker on mac-arm #10848

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Tristramg
Copy link
Contributor

No description provided.

@Tristramg Tristramg requested a review from a team as a code owner February 18, 2025 12:54
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (3e1768d) to head (e5eee56).
Report is 32 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10848      +/-   ##
==========================================
+ Coverage   82.56%   82.60%   +0.04%     
==========================================
  Files        1084     1084              
  Lines      107256   107442     +186     
  Branches      728      729       +1     
==========================================
+ Hits        88558    88756     +198     
+ Misses      18657    18644      -13     
- Partials       41       42       +1     
Flag Coverage Δ
editoast 74.42% <ø> (+0.01%) ⬆️
front 90.51% <ø> (+0.04%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on a mac M3 Pro Sequoia 15.0.1

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@woshilapin
Copy link
Contributor

Just a suggestion, do you think this is where we could try binstall. cargo-binstall does ship a musl release (which should not be impacted by the problem we have?), and then, maybe (maybe ?) cargo binstall will be able to realize if it needs to build or if it can download from Github's release?

Because to be honest, editoast build is already the longer one and using cargo install will make it even longer.

@flomonster
Copy link
Contributor

Because to be honest, editoast build is already the longer one and using cargo install will make it even longer.

I don't think it's going to make the editoast build any longer. The internship can be done completely in parallel with editoast.

Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
@flomonster flomonster enabled auto-merge February 19, 2025 15:41
@flomonster flomonster added this pull request to the merge queue Feb 19, 2025
Merged via the queue into dev with commit 452bed2 Feb 19, 2025
27 checks passed
@flomonster flomonster deleted the fix_glyph_macos_arm branch February 19, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants