-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: fix glyph generation on docker on mac-arm #10848
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10848 +/- ##
==========================================
+ Coverage 82.56% 82.60% +0.04%
==========================================
Files 1084 1084
Lines 107256 107442 +186
Branches 728 729 +1
==========================================
+ Hits 88558 88756 +198
+ Misses 18657 18644 -13
- Partials 41 42 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on a mac M3 Pro Sequoia 15.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
Just a suggestion, do you think this is where we could try Because to be honest, |
I don't think it's going to make the editoast build any longer. The internship can be done completely in parallel with editoast. |
Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu> Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
96b924d
to
e5eee56
Compare
No description provided.