Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: collapse sidebar when infra load #10871

Merged
merged 1 commit into from
Feb 24, 2025
Merged

front: collapse sidebar when infra load #10871

merged 1 commit into from
Feb 24, 2025

Conversation

theocrsb
Copy link
Contributor

closes #10862

Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb requested review from kmer2016 and Yohh February 20, 2025 11:59
@theocrsb theocrsb requested a review from a team as a code owner February 20, 2025 11:59
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (975ec76) to head (9c4614c).
Report is 29 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10871      +/-   ##
==========================================
- Coverage   82.60%   82.60%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107448   107444       -4     
  Branches      729      729              
==========================================
- Hits        88761    88756       -5     
- Misses      18645    18646       +1     
  Partials       42       42              
Flag Coverage Δ
editoast 74.41% <ø> (-0.01%) ⬇️
front 90.51% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theocrsb theocrsb added this pull request to the merge queue Feb 24, 2025
Merged via the queue into dev with commit 0933dbc Feb 24, 2025
27 checks passed
@theocrsb theocrsb deleted the tce/collapse/sidebar branch February 24, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't uncollapse sidebar while infra is loading
4 participants