front: drop TimeButtons, TrainDetails and ChartSynchronizer #10881
+3
−1,630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarani
reviewed
Feb 24, 2025
emersion
force-pushed
the
emr/drop-sticky-bar
branch
from
f96e5ec to
d5ebb68
Compare
|
All done! |
clarani
reviewed
Feb 27, 2025
front/src/modules/simulationResult/components/ChartHelpers/ChartHelpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SimulationResultsMap/helpers.ts
Outdated
Show resolved
Hide resolved
These are unused at the moment, because the whole thing is hidden. The code is bit-rotting and holding off refactoring. Let's just nuke all of that. Maybe this feature will be re-introduced at some point, but we'll need to rewrite big chunks of it anyways and we can easily copy back useful bits from the Git history. Signed-off-by: Simon Ser <contact@emersion.fr>
This is now unused. Signed-off-by: Simon Ser <contact@emersion.fr>
This is now unused. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/drop-sticky-bar
branch
from
d5ebb68 to
9677280
Compare
|
Removed! I also ended up nuking |
These are now unused. Signed-off-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/drop-sticky-bar
branch
from
9677280 to
a358673
Compare
clarani
reviewed
Mar 5, 2025
|
If you end up dropping TrainOnMap, please also drop the train layer and layer group in front/src/config/layerOrder.ts ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are unused at the moment, because the whole thing is hidden. The code is bit-rotting and holding off refactoring.
Let's just nuke all of that. Maybe this feature will be re-introduced at some point, but we'll need to rewrite big chunks of it anyways and we can easily copy back useful bits from the Git history.