Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: invert signs on the tolerance range in the simulation sheet #10912

Merged
merged 1 commit into from
Feb 26, 2025
Merged

front: invert signs on the tolerance range in the simulation sheet #10912

merged 1 commit into from
Feb 26, 2025

Conversation

theocrsb
Copy link
Contributor

closes #10899

@theocrsb theocrsb requested a review from a team as a code owner February 24, 2025 13:20
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.55%. Comparing base (b53ba93) to head (ad30d07).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10912      +/-   ##
==========================================
- Coverage   82.56%   82.55%   -0.01%     
==========================================
  Files        1087     1087              
  Lines      108107   108129      +22     
  Branches      742      742              
==========================================
+ Hits        89254    89269      +15     
- Misses      18811    18818       +7     
  Partials       42       42
Flag Coverage Δ
editoast 74.38% <ø> (-0.01%) ⬇️
front 90.38% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SharglutDev
SharglutDev approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@theocrsb theocrsb enabled auto-merge February 24, 2025 13:39
Caracol3
Caracol3 approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

@theocrsb theocrsb force-pushed the tce/inverted-sign branch 2 times, most recently from b56a8f2 to 367ab0e Compare February 25, 2025 08:51
@theocrsb theocrsb requested a review from a team as a code owner February 25, 2025 08:51
@theocrsb theocrsb force-pushed the tce/inverted-sign branch 2 times, most recently from 60e9977 to 8bffab3 Compare February 25, 2025 09:56
@SharglutDev SharglutDev requested review from Yohh and Maymanaf February 25, 2025 11:49
Maymanaf
Maymanaf approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
You can simply merge after reverting the order

@theocrsb theocrsb added this pull request to the merge queue Feb 25, 2025
@Maymanaf Maymanaf removed this pull request from the merge queue due to a manual request Feb 25, 2025
@theocrsb theocrsb force-pushed the tce/inverted-sign branch 2 times, most recently from 3adf234 to 8017eb8 Compare February 25, 2025 14:22
@theocrsb theocrsb requested a review from emersion February 25, 2025 14:44
@theocrsb
front: convert signs on the tolerance range in the simulation sheet
ad30d07 
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb requested a review from emersion February 25, 2025 16:27
@theocrsb
Copy link
Contributor Author

After speaking with @thibautsailly, I had to reverse the tolerance layout.

SharglutDev
SharglutDev approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the re-change

@SharglutDev SharglutDev added this pull request to the merge queue Feb 26, 2025
Merged via the queue into dev with commit ab8cf51 Feb 26, 2025
27 checks passed
@SharglutDev SharglutDev deleted the tce/inverted-sign branch February 26, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maymanaf Maymanaf Maymanaf approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

@Yohh Yohh Awaiting requested review from Yohh

@Caracol3 Caracol3 Awaiting requested review from Caracol3

@emersion emersion Awaiting requested review from emersion

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STDCM: inverted signs on tolerance range in simulation sheet
7 participants
@theocrsb @codecov-commenter @emersion @Maymanaf @Yohh @SharglutDev @Caracol3