Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front: fix stdcm config crash when changing scenario in stdcm debug #10975

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 27, 2025

closes #10973

Thanks to the first commit, from now on, if a user selects an empty timetable in STDCM, then he will be able to request a train with a departure within the current day.

@clarani clarani requested a review from a team as a code owner February 27, 2025 14:36
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (37c3b08) to head (da5a617).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10975      +/-   ##
==========================================
- Coverage   80.66%   80.66%   -0.01%     
==========================================
  Files        1098     1098              
  Lines      111787   111785       -2     
  Branches      744      745       +1     
==========================================
- Hits        90176    90171       -5     
- Misses      21568    21571       +3     
  Partials       43       43              
Flag Coverage Δ
editoast 72.22% <ø> (ø)
front 89.93% <97.50%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/10973-stdcm-config-crash branch from 4c5e1de to da019ed Compare February 28, 2025 10:44
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you !

@clarani clarani force-pushed the cni/10973-stdcm-config-crash branch from da019ed to b80310a Compare March 3, 2025 14:36
@clarani clarani enabled auto-merge March 3, 2025 14:42
@clarani clarani force-pushed the cni/10973-stdcm-config-crash branch from b80310a to 15abce3 Compare March 3, 2025 15:01
clarani added 3 commits March 3, 2025 16:01
If a timetable is empty, return a Datetime window for the current day.

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
…he user

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/10973-stdcm-config-crash branch from 15abce3 to da5a617 Compare March 3, 2025 15:01
@clarani clarani added this pull request to the merge queue Mar 3, 2025
Merged via the queue into dev with commit 1bd3872 Mar 3, 2025
27 checks passed
@clarani clarani deleted the cni/10973-stdcm-config-crash branch March 3, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: crash when selecting scenario in debug "STDCM conf is not valid"
3 participants