-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETCS braking curves #1737
Closed
Closed
ETCS braking curves #1737
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7cc6464
core: ertms: update RollingStock model and create first ETCS class an…
0a43376
core: ertms: wip
129bb5b
core: ertms : compute gammaBrakeEmergency
bgiuliana 6488b41
core: ertms: error management for rolling stock gamma queries
0496f54
core: ertms: implement BrakingCurves
ee9f8cf
core: ertms: create tests for EBD braking curves
4896f45
core: ertms: implement SBD (wip)
c6d0c82
core: ertms: wip
1df9997
core: ertms: re-arrange useCases in TrainPhysicsIntegrator until it w…
bdac8bb
core: ertms: update values of ETCS coefficients in TestTrains
8f8c1ec
core: ertms: fix tests
ea4bc54
core: ertms: introducing constant values and new correction factors
04b4e5f
core: ertms: implement GUI
f719470
core: ertms: add a bunch of fixed value data
e8349d4
core: ertms: implement EBI
264eb2f
core: ertms: make most methods return Envelopes instead of List<Envel…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
core/src/main/java/fr/sncf/osrd/envelope_sim/EnvelopeSimContext.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,34 @@ | ||
package fr.sncf.osrd.envelope_sim; | ||
|
||
public class EnvelopeSimContext { | ||
|
||
public enum UseCase { | ||
TIMETABLE, | ||
RUNNING_TIME, | ||
ETCS_EBD, | ||
ETCS_SBD, | ||
ETCS_GUI | ||
} | ||
|
||
public final PhysicsRollingStock rollingStock; | ||
public final PhysicsPath path; | ||
public final double timeStep; | ||
|
||
public final UseCase useCase; | ||
|
||
/** Creates a context suitable to run simulations on envelopes */ | ||
public EnvelopeSimContext(PhysicsRollingStock rollingStock, PhysicsPath path, double timeStep) { | ||
this.rollingStock = rollingStock; | ||
this.path = path; | ||
this.timeStep = timeStep; | ||
this.useCase = UseCase.TIMETABLE; | ||
} | ||
|
||
/** Creates a context suitable to run a specific ETCS braking curve envelopePart */ | ||
public EnvelopeSimContext(PhysicsRollingStock rollingStock, PhysicsPath path, double timeStep, UseCase useCase) { | ||
this.rollingStock = rollingStock; | ||
this.path = path; | ||
this.timeStep = timeStep; | ||
this.useCase = useCase; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method returns the "largest" negative grade, it seems to be the intended behavior but I'd prefer if we have a comment that explains it (both here and in the api file). I'd expect a function named
getLowest
to return something close to 0