Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: update all 'opentelemetry' related dependencies #8713

Closed
wants to merge 1 commit into from
Closed

editoast: update all 'opentelemetry' related dependencies #8713

wants to merge 1 commit into from

Conversation

woshilapin
Copy link
Contributor

All Opentelemetry dependencies must be updated all at once (Dependabot can't really understand that). Here is the PR.

@woshilapin woshilapin requested a review from a team as a code owner September 3, 2024 09:27
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (f2f2cc9) to head (e7b91f9).
Report is 171 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #8713   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files          31       31           
  Lines        1535     1535           
=======================================
  Hits         1343     1343           
  Misses        192      192
Flag Coverage Δ
railjson_generator 87.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin
Copy link
Contributor Author

Seems like upgrading these dependencies means also that we need to upgrade minimum version of Rust

error: rustc 1.79.0 is not supported by the following package:
  axum-tracing-opentelemetry@0.19.1 requires rustc 1.80.0
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.79.0

Are we ok with such a change ?

@woshilapin woshilapin force-pushed the wsl/editoast/chore/update-opentelemetry branch from 22b95fd to 11816e7 Compare September 3, 2024 09:42
@woshilapin woshilapin requested a review from a team as a code owner September 3, 2024 09:42
@woshilapin woshilapin force-pushed the wsl/editoast/chore/update-opentelemetry branch from 11816e7 to 09cf99c Compare September 3, 2024 10:02
@woshilapin
Copy link
Contributor Author

woshilapin commented Sep 3, 2024 •
edited
Loading

Argh, installation of grcov doesn't work with Rust 1.80 because they didn't update time version... Brrrrr, should we start thinking of moving away of grcov (no update on the subject since June)? Until we decide, I believe removing --locked will do the trick...

@woshilapin woshilapin force-pushed the wsl/editoast/chore/update-opentelemetry branch from 09cf99c to e7b91f9 Compare September 3, 2024 10:06
@Khoyo
Copy link
Contributor

Khoyo commented Sep 3, 2024

no update on the subject since June?

No commits on master since almost a year ago

flomonster
flomonster approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

woshilapin added a commit that referenced this pull request Sep 25, 2024
@woshilapin
ci, editoast: update 'opentelemetry' dependencies all at once
ea4eb9b 
By default, Dependabot opens a new PR for each dependency.
However, it doesn't work well for OpenTelemetry ecosystem which
usually require a manual operation (see #7102, #7569, #8713).

This modification in how Dependabot operates should help a bit.
See [documentation](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups)

Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
woshilapin added a commit that referenced this pull request Sep 25, 2024
@woshilapin
ci, editoast: update 'opentelemetry' dependencies all at once
268f969 
By default, Dependabot opens a new PR for each dependency.
However, it doesn't work well for OpenTelemetry ecosystem which
usually require a manual operation (see #7102, #7569, #8713).

This modification in how Dependabot operates should help a bit.
See [documentation](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups)

Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
@woshilapin
ci, editoast: update 'opentelemetry' dependencies all at once
8ed9a24 
By default, Dependabot opens a new PR for each dependency.
However, it doesn't work well for OpenTelemetry ecosystem which
usually require a manual operation (see #7102, #7569, #8713).

This modification in how Dependabot operates should help a bit.
See [documentation](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups)

Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
@woshilapin
Copy link
Contributor Author

I'm closing this PR since it doesn't work and it's already out of date anyway (see #9005 which will need to be fixed too).

@woshilapin woshilapin closed this Sep 26, 2024
@woshilapin woshilapin deleted the wsl/editoast/chore/update-opentelemetry branch October 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@Khoyo Khoyo Khoyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woshilapin @codecov-commenter @Khoyo @flomonster