Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add 'core' connectivity to the healthcheck #9393

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

woshilapin
Copy link
Contributor

We should also check connectivity to the core for the healthcheck.

@woshilapin woshilapin requested a review from a team as a code owner October 18, 2024 16:46
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 38.88889% with 22 lines in your changes missing coverage. Please review.

Project coverage is 39.24%. Comparing base (f6e8d72) to head (72929e6).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/core/mq_client.rs 0.00% 12 Missing ⚠️
editoast/src/client/mod.rs 0.00% 8 Missing ⚠️
editoast/src/core/mod.rs 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9393      +/-   ##
============================================
- Coverage     39.25%   39.24%   -0.02%     
  Complexity     2267     2267              
============================================
  Files          1304     1305       +1     
  Lines         98740    98783      +43     
  Branches       3303     3310       +7     
============================================
+ Hits          38763    38767       +4     
- Misses        58023    58055      +32     
- Partials       1954     1961       +7     
Flag Coverage Δ
core 74.97% <ø> (ø)
editoast 71.95% <38.88%> (-0.07%) ⬇️
front 10.35% <ø> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the front part ✅

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants