Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: create type StdcmPathStep #9428

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 22, 2024

closes #9392

  • create a new type StdcmPathStep
  • add a new props stdcmPathSteps to the stdcmStore
  • create new actions: updateStdcmPathStep, addStdcmVia, removeStdcmVia
  • create new selectors: getStdcmPathSteps, getStdcmOrigin, getStdcmDestination
  • clean:
    • remove several actions: updateOriginArrival, updateDestinationArrival, updateOriginArrivalType, updateDestinationArrivalType, updateOriginTolerances, updateDestinationTolerances
    • clean some stdcm components

@clarani clarani requested a review from a team as a code owner October 22, 2024 15:23
@emersion emersion self-requested a review October 22, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.73%. Comparing base (f79e009) to head (668603c).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #9428       +/-   ##
=============================================
+ Coverage     39.07%   65.73%   +26.65%     
  Complexity     2267     2267               
=============================================
  Files          1308      680      -628     
  Lines         99202    51451    -47751     
  Branches       3312     2170     -1142     
=============================================
- Hits          38765    33822     -4943     
+ Misses        58474    16801    -41673     
+ Partials       1963      828     -1135     
Flag Coverage Δ
core 74.93% <ø> (ø)
editoast 71.95% <ø> (-0.04%) ⬇️
front ?
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/9392-refacto-stdcm-store branch from ee84329 to 668603c Compare October 23, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: refacto stdcm store
2 participants