Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x-remote-user usage #9602

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix x-remote-user usage #9602

merged 1 commit into from
Nov 7, 2024

Conversation

flomonster
Copy link
Contributor

  • Editoast: stop splitting the provider and the identity id
  • Gateway: provide the x-remote-name (match the design doc)

@flomonster flomonster requested review from a team as code owners November 6, 2024 16:14
@flomonster flomonster changed the title editoast, gateway: fix x-remote-user usage Fix x-remote-user usage Nov 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 37.13%. Comparing base (0e1ea9b) to head (dbc75f8).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
gateway/src/request_modifier.rs 0.00% 15 Missing ⚠️
editoast/src/views/mod.rs 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (0e1ea9b) and HEAD (dbc75f8). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (0e1ea9b) HEAD (dbc75f8)
railjson_generator 2 1
osrdyne 2 1
gateway 2 1
tests 2 1
front 2 1
core 2 0
editoast 2 1
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #9602      +/-   ##
============================================
- Coverage     42.51%   37.13%   -5.39%     
============================================
  Files          1311      987     -324     
  Lines        105413    90491   -14922     
  Branches       3297     1122    -2175     
============================================
- Hits          44812    33600   -11212     
+ Misses        58655    55776    -2879     
+ Partials       1946     1115     -831
Flag Coverage Δ
core ?
editoast 73.68% <0.00%> (-0.03%) ⬇️
front 18.79% <ø> (ø)
gateway 2.18% <0.00%> (-0.02%) ⬇️
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Khoyo
Khoyo approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested

ElysaSrc
ElysaSrc approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if It works on dev

leovalais
leovalais approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@woshilapin woshilapin mentioned this pull request Nov 6, 2024
Merged
bloussou
bloussou approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool perfect !

@flomonster flomonster force-pushed the fam/fix-user-identity branch from 41daecf to 2c6d50e Compare November 7, 2024 08:34
@flomonster flomonster enabled auto-merge November 7, 2024 08:34
@flomonster
editoast, gateway: fix x-remote-user usage
dbc75f8 
- Editoast: stop splitting the provider and the identity id
- Gateway: provide the x-remote-name (match the design doc)

Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
@flomonster flomonster force-pushed the fam/fix-user-identity branch from 2c6d50e to dbc75f8 Compare November 7, 2024 10:40
@flomonster flomonster added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@Khoyo Khoyo added this pull request to the merge queue Nov 7, 2024
Merged via the queue into dev with commit 6dcee88 Nov 7, 2024
24 checks passed
@Khoyo Khoyo deleted the fam/fix-user-identity branch November 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khoyo Khoyo Khoyo approved these changes

@woshilapin woshilapin woshilapin approved these changes

@leovalais leovalais leovalais approved these changes

@bloussou bloussou bloussou approved these changes

@ElysaSrc ElysaSrc ElysaSrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@flomonster @codecov-commenter @Khoyo @woshilapin @leovalais @bloussou @ElysaSrc