Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add sticky position on stdcm map and convert rem to px #9701

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

theocrsb
Copy link
Contributor

closes #9684

@theocrsb theocrsb requested a review from a team as a code owner November 14, 2024 08:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.82%. Comparing base (da5c5b1) to head (0917cf1).
Report is 32 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9701      +/-   ##
============================================
- Coverage     42.49%   37.82%   -4.67%     
============================================
  Files          1312      990     -322     
  Lines        105608    90920   -14688     
  Branches       3305     1176    -2129     
============================================
- Hits          44881    34393   -10488     
+ Misses        58774    56073    -2701     
+ Partials       1953      454    -1499     
Flag Coverage Δ
core ?
editoast 73.21% <ø> (-0.52%) ⬇️
front 20.11% <ø> (+1.32%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus changed the title front: add sticky postion on lmr map and convert rem to px front: add sticky position on lmr map and convert rem to px Nov 15, 2024
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb force-pushed the tce/front/lmr/sticky-map branch from 9b8ca76 to bd1485b Compare November 15, 2024 09:16
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM !

@theocrsb theocrsb changed the title front: add sticky position on lmr map and convert rem to px front: add sticky position on stdcm map and convert rem to px Nov 15, 2024
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, you can resolve the last comments and merge :)

@theocrsb theocrsb force-pushed the tce/front/lmr/sticky-map branch from bd1485b to 4480282 Compare November 15, 2024 15:54
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb force-pushed the tce/front/lmr/sticky-map branch from 4480282 to 0917cf1 Compare November 15, 2024 15:56
@theocrsb theocrsb enabled auto-merge November 15, 2024 16:10
@theocrsb theocrsb added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@theocrsb theocrsb added this pull request to the merge queue Nov 16, 2024
Merged via the queue into dev with commit b4b2d7f Nov 16, 2024
27 checks passed
@theocrsb theocrsb deleted the tce/front/lmr/sticky-map branch November 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STDCM Map should be sticky to the top
4 participants