Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: display electrical profile set name in scenario #9870

Merged
merged 1 commit into from
Nov 28, 2024
Merged

front: display electrical profile set name in scenario #9870

merged 1 commit into from
Nov 28, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 26, 2024

closes #8002

After:
image

@clarani clarani requested a review from a team as a code owner November 26, 2024 16:29
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 26, 2024
@clarani clarani requested review from Math-R and Akctarus November 26, 2024 16:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 38.20%. Comparing base (990c8fa) to head (b2a77fe).
Report is 30 commits behind head on dev.

Files with missing lines Patch % Lines
...tudies/components/Scenario/ScenarioDescription.tsx 0.00% 18 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9870      +/-   ##
==========================================
- Coverage   38.22%   38.20%   -0.03%     
==========================================
  Files         995      995              
  Lines       91883    91925      +42     
  Branches     1189     1193       +4     
==========================================
- Hits        35125    35119       -6     
- Misses      56304    56351      +47     
- Partials      454      455       +1
Flag Coverage Δ
editoast 73.31% <ø> (-0.02%) ⬇️
front 20.19% <0.00%> (-0.05%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/8002-display-electrical-profile-set-name branch from e371751 to ebe00a3 Compare November 27, 2024 14:08
@SharglutDev
Copy link
Contributor

Regarding your screenshot, it doesn't quite match the mockup : https://www.sketch.com/s/2fb064cd-c483-46ac-bd30-72705fd63e75/p/9935859D-9F0B-489C-9C2D-1E55C396D8DC/canvas

We should still see : "Profils électriques : FRANCE GAIA"

Akctarus
Akctarus approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM, left a question in comment

@clarani
Copy link
Contributor Author

clarani commented Nov 28, 2024 •
edited
Loading

I modified my PR, here is what it looks like now:
image

@clarani clarani force-pushed the cni/8002-display-electrical-profile-set-name branch from ebe00a3 to 1f09e9f Compare November 28, 2024 08:29
@clarani clarani enabled auto-merge November 28, 2024 08:32
@clarani
front: display electrical profile set name in scenario
b2a77fe 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/8002-display-electrical-profile-set-name branch from 1f09e9f to b2a77fe Compare November 28, 2024 08:33
Math-R
Math-R approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! thanks !

@clarani clarani added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit 28917fb Nov 28, 2024
27 checks passed
@clarani clarani deleted the cni/8002-display-electrical-profile-set-name branch November 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akctarus Akctarus Akctarus approved these changes

@Math-R Math-R Math-R approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name of the electrical profile set chosen for the scenario isn't displayed
5 participants
@clarani @codecov-commenter @SharglutDev @Math-R @Akctarus