front: add ManageTrainSchedule context and remove Pathfinding's reducer #9924

clarani · 2024-12-03T10:41:59Z

closes #9915
closes #9902 (because the power restrictions were reset by the call to usePathfinding in the RollingStockSelector)
will also close #6719
and fix #10038

clarani · 2024-12-03T10:42:44Z

Need to wait for #9901 first

codecov-commenter · 2024-12-03T10:44:16Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 149 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (a64f77b) to head (6d107d8).
Report is 6 commits behind head on dev.

Files with missing lines	Patch %	Lines
...nt/src/modules/pathfinding/hooks/usePathfinding.ts	7.37%	113 Missing ⚠️
...nalStudies/hooks/useManageTrainScheduleContext.tsx	10.25%	35 Missing ⚠️
...alStudies/hooks/useSetupItineraryForTrainUpdate.ts	50.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9924      +/-   ##
==========================================
- Coverage   79.90%   79.79%   -0.11%     
==========================================
  Files        1052     1052              
  Lines      105602   105434     -168     
  Branches      759      727      -32     
==========================================
- Hits        84378    84133     -245     
- Misses      21182    21259      +77     
  Partials       42       42

Flag	Coverage Δ
editoast	`73.70% <ø> (-0.05%)`	⬇️
front	`89.12% <50.00%> (-0.13%)`	⬇️
gateway	`2.18% <ø> (ø)`
osrdyne	`3.28% <ø> (ø)`
railjson_generator	`87.50% <ø> (ø)`
tests	`87.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

front/src/modules/trainschedule/components/ManageTrainSchedule/Map.tsx

front/src/modules/pathfinding/hooks/usePathfinding.ts

front/src/applications/operationalStudies/hooks/useManageTrainScheduleContext.tsx

emersion

Excellent work! Thanks so much for splitting into separate commits. Here are a few comments :)

SharglutDev

Great refacto, thanks for that !

front/src/modules/pathfinding/components/Itinerary/ModalSuggestedVias.tsx

front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/Vias.tsx

front/src/modules/pathfinding/components/Pathfinding/Pathfinding.tsx

front/src/modules/pathfinding/hooks/usePathfinding.ts

front/src/modules/pathfinding/components/Itinerary/Itinerary.tsx

front/src/modules/pathfinding/components/Pathfinding/TypeAndPath.tsx

front/src/applications/operationalStudies/hooks/useManageTrainScheduleContext.tsx

front/src/modules/pathfinding/components/Pathfinding/Pathfinding.tsx

front/src/modules/pathfinding/components/Pathfinding/TypeAndPath.tsx

...c/modules/trainschedule/components/ManageTrainSchedule/ManageTrainScheduleMap/setPointIti.ts

SharglutDev

Lgtm and tested, great job !

anisometropie

thanks, good reworking

SharglutDev

Lgtm and tested again :)

Signed-off-by: Clara Ni <clara.ni@outlook.fr>

clarani requested a review from a team as a code owner December 3, 2024 10:42

github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 3, 2024

clarani marked this pull request as draft December 3, 2024 10:42

clarani force-pushed the cni/9915-add-manage-train-schedule-context branch from 8560c51 to 03e7f27 Compare December 3, 2024 16:41

clarani marked this pull request as ready for review December 3, 2024 16:43

clarani requested review from emersion and SharglutDev December 3, 2024 17:04

anisometropie mentioned this pull request Dec 4, 2024

front: call pathfinding only once #9733

Closed