-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix constraint distribution state in simulation settings #9932
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9932 +/- ##
==========================================
- Coverage 80.04% 80.02% -0.02%
==========================================
Files 1049 1049
Lines 105292 105293 +1
Branches 757 758 +1
==========================================
- Hits 84277 84259 -18
- Misses 20974 20993 +19
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum it would be better to fix this directly in the action selectTrainToEdit
;) you can get the constraint_distribution
of the trainSchedule there and directly set the state
9b258e8
to
3de2fda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
c4188e1
to
be6e812
Compare
Signed-off-by: romainvalls <romain.valls95@gmail.com>
be6e812
to
278a86b
Compare
close #9811