fix: Off by one error (#1001)

Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
OpenRakis · Dec 29, 2024 · 16db6e2 · 16db6e2
1 parent 356bef5
commit 16db6e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Spice86/MemoryWrappers/DataMemoryDocument.cs b/src/Spice86/MemoryWrappers/DataMemoryDocument.cs
@@ -5,6 +5,7 @@
 
 using System;
 
+/// <inheritdoc cref="IBinaryDocument" />
 public sealed class DataMemoryDocument : IBinaryDocument {
     private readonly IMemory _memory;
     private readonly uint _startAddress;
@@ -17,7 +18,7 @@ public DataMemoryDocument(IMemory memory, uint startAddress, uint endAddress) {
         _startAddress = startAddress;
         _endAddress = endAddress;
         _memory = memory;
-        ValidRanges = new MemoryReadOnlyBitRangeUnion(0, _endAddress + 1 - _startAddress);
+        ValidRanges = new MemoryReadOnlyBitRangeUnion(0, _endAddress - _startAddress);
     }
 
     public event Action<Exception>? MemoryReadInvalidOperation;

diff --git a/src/Spice86/MemoryWrappers/MemoryReadOnlyBitRangeUnion.cs b/src/Spice86/MemoryWrappers/MemoryReadOnlyBitRangeUnion.cs
@@ -17,7 +17,7 @@ internal class MemoryReadOnlyBitRangeUnion : IReadOnlyBitRangeUnion {
     /// Initializes a new instance of the <see cref="MemoryReadOnlyBitRangeUnion"/> class.
     /// </summary>
     /// <param name="startAddress">The start address of tha range of memory.</param>
-    /// <param name="endAddress">The end address of the range of memory. This end address is not included in the range.</param>
+    /// <param name="endAddress">The end address of the range of memory.</param>
     public MemoryReadOnlyBitRangeUnion(uint startAddress, uint endAddress) {
         _startAddress = startAddress;
         _endAddress = endAddress;