Rework Memory class #369
Merged
Rework Memory class #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Make indexers depend on IByteReaderWriter instead of memory and create a new interface to represent Indexer 8 / 16 / 32 holders which is IIndexed
kevinferrare
force-pushed
the
memory_indexer_rework
branch
from
5fce324
to
6d273ca
Compare
maximilien-noal
added
reverse engineering
maximilien-noal
approved these changes
Jul 7, 2023
kevinferrare
force-pushed
the
memory_indexer_rework
branch
from
6d273ca
to
76b25a3
Compare
maximilien-noal
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Get / Set methods, use indexers everywhere.
Make indexers depend on IByteReaderWriter instead of Memory.
Create a new IIndexed interface to represent Indexer 8 / 16 / 32 holders.
Motivation: to be able to use a byte array as IIndexed for memory dumps.