Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: UI crash on app exit and refactor: UI _drawAction became a method #567

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Fix: UI crash on app exit and refactor: UI _drawAction became a method #567

merged 5 commits into from
Jan 24, 2024

Commits on Jan 23, 2024

  1. UI: Fix crash on app exit with Dispose 

    Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
    @maximilien-noal
    maximilien-noal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5f310c5 View commit details
    Browse the repository at this point in the history

  2. refactor: replaced _drawAction with method 

    Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
    @maximilien-noal
    maximilien-noal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7a27dad View commit details
    Browse the repository at this point in the history

  3. renamed PR github workflow 

    Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
    @maximilien-noal
    maximilien-noal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    91202ca View commit details
    Browse the repository at this point in the history

  4. UI: Initialize timer once 

    Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
    @maximilien-noal
    maximilien-noal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    45e3fa5 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. UI: set _disposed to true early 

    Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
    @maximilien-noal
    maximilien-noal committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    da86536 View commit details
    Browse the repository at this point in the history